HBASE-29541 Removing unnecessary sanitization in throttle metrics #7238
+2
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This looks good to me, cc @rmdmattingly @charlesconnell, any chance you could take a look at this? For context, we don't do this type of sanitation anywhere else in the code, and were worried of any potential overhead |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Pull Request Overview
This PR removes unnecessary sanitization and null handling from throttle metrics reporting in HBase. The changes simplify the metrics naming by eliminating character replacement for JMX compatibility and removing null value handling since those values should never be null in practice.
Key changes:
- Removed sanitization logic that replaced JMX-problematic characters with underscores
- Eliminated null handling that converted null values to "unknown"
- Updated tests to remove coverage for the removed functionality
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| MetricsThrottleExceptions.java | Removed sanitizeMetricName method and simplified qualifyThrottleMetric to use raw user/table names |
| TestMetricsThrottleExceptions.java | Removed tests for metric name sanitization and null handling, updated expected metric name format |
| TestMetricsRegionServer.java | Removed integration tests for sanitization and null handling scenarios |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes some unnecessary sanitization we were doing in the throttle metrics reporting. Also, removes the null handling as those values should never be null.